Skip to content

chore: add clippy CI tests #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2025
Merged

chore: add clippy CI tests #4411

merged 3 commits into from
Apr 15, 2025

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Apr 15, 2025

run cargo clippy for all targets

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added ctest Issues relating to the ctest crate S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 15, 2025
nyurik added 2 commits April 14, 2025 22:57
@nyurik
chore: add clippy CI tests
bea4d1b 
run cargo clippy for all targets
@nyurik
simplify clippy ci
5997a8b
@rustbot rustbot added the A-CI Area: CI-related items label Apr 15, 2025
tgross35
tgross35 requested changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running Clippy has been on the todo list for a while, thanks for adding it. Some small feedback.

@nyurik
Copy link
Contributor Author

nyurik commented Apr 15, 2025

thx, fixed

tgross35
tgross35 approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgross35 tgross35 added this pull request to the merge queue Apr 15, 2025
Merged via the queue into rust-lang:main with commit 0fe1d45 Apr 15, 2025
50 checks passed
@nyurik nyurik deleted the clippy branch April 15, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
A-CI Area: CI-related items ctest Issues relating to the ctest crate S-waiting-on-author stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyurik @rustbot @tgross35