adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file #150368

paradoxicalguy · 2025-12-25T12:41:17Z

this adds the Ordering enum to minicore.rs.

consequently, this updates tests/assembly-llvm/rust-abi-arg-attr.rs to import minicore directly. previously, this test file contained traits like Copy Clone PointeeSized, which were giving a duplicate lang item error, so replace those by importing minicore completely.

rustbot · 2025-12-25T12:41:20Z

This PR modifies tests/auxiliary/minicore.rs.

cc @jieyouxu

rustbot · 2025-12-25T12:41:22Z

Mark-Simulacrum is not on the review rotation at the moment.
They may take a while to respond.

rustbot · 2025-12-25T12:41:23Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

workingjubilee

This doesn't actually remove any diverging definitions from tests?

View changes since this review

workingjubilee · 2025-12-26T00:53:49Z

tests/auxiliary/minicore.rs


 #[lang = "c_void"]
-#[repr(u8)]
+#[repr(C)]


This is not how c_void is defined in core::ffi. Please revert this unrelated change.

workingjubilee · 2025-12-26T00:54:21Z

tests/auxiliary/minicore.rs

+#[lang = "Ordering"]
+#[repr(i8)]
+pub enum Ordering {
+    Less = 0xFFu8 as i8,


I'm sorry?

You can just write -1, can't you?

it was giving an error before, reverted it back

workingjubilee · 2025-12-26T00:55:21Z

tests/auxiliary/minicore.rs

+#[rustc_nounwind]
+#[rustc_intrinsic]
+pub const fn three_way_compare<T: Copy>(lhs: T, rhs: T) -> Ordering;


Why are you also adding this?

tests/assembly-llvm/rust-abi-arg-attr.rs - uses Ordering and three_way_compare

rustbot · 2025-12-26T00:56:25Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

paradoxicalguy · 2025-12-26T08:14:01Z

fixed minicore issues, aligned ordering and usize behavior, ready for re-review
@rustbot ready

paradoxicalguy · 2025-12-26T11:44:27Z

@rustbot ready

paradoxicalguy · 2025-12-26T12:28:43Z

@workingjubilee
i used 0xFFu8 as i8 instead of -1 because in #![no_core] context, the unary - operator requires the Neg lang item and an impl Neg for i8, which aren't currently in minicore.

adding impl Neg for i8 just to support this discriminant would introduce operator semantics (arithmetic, overflow handling, MIR lowering) which minicore intentionally avoids. the 0xFFu8 as i8 approach uses pure constant evaluation with no operator traits or lang items required

if you'd prefer -1 for readability, i can add the Neg implementation

workingjubilee · 2025-12-26T22:16:13Z

don't quote the deep magic to me. I was there when it was written.

minicore is minimal for the sake of not reimplementing all of core, nothing more.

paradoxicalguy · 2025-12-27T21:27:19Z

#150423
new pr generated

paradoxicalguy · 2025-12-30T22:11:34Z

@workingjubilee i have added the Ordering enum in minicore.rs file
just pinging you for a design choice as i am hitting a duplicating lang error when i import minicore in rust-abi-arg-attr.rs file for other traits like Copy, Clone etc,
is there a specific way you prefer we handle these trait collisions?

i found 2 ways to fix it which passes locally:

option a: removing the duplicating traits from rust-abi-arg-attr.rs test file and just importing minicore
option b: keeping both files separate and independent
or any different way which you think might be the best.

rustbot · 2025-12-31T06:54:50Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

paradoxicalguy · 2025-12-31T07:59:23Z

@workingjubilee i have closed the duplicate PR and pushed the minicore changes here,

CI failure is the duplicate lang item issue i asked in my previous comment, when importing minicore, it conflicts with the local trait definitions in the test file.
just need your preference on which direction to take.

paradoxicalguy · 2026-01-04T18:47:25Z

@workingjubilee just following up, waiting for whichever solution you prefer for the duplicate lang item error. i'll update the PR

workingjubilee · 2026-01-09T03:04:26Z

@paradoxicalguy It seems that this test was the only one that actually used lang = "Ordering". Correct the PR description, please.

It's arguably fine to make the change since it makes it easier to write certain tests and verify they cross-compile. But "some" is awfully vague when it's just 1.

workingjubilee · 2026-01-09T04:30:11Z

@bors r+

rust-bors · 2026-01-09T04:30:14Z

📌 Commit 484ea76 has been approved by workingjubilee

It is now in the queue for this repository.

paradoxicalguy · 2026-01-09T04:32:56Z

yay :-D

adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file this adds the `Ordering` enum to `minicore.rs`. consequently, this updates `tests/assembly-llvm/rust-abi-arg-attr.rs` to import `minicore` directly. previously, this test file contained traits like `Copy` `Clone` `PointeeSized`, which were giving a duplicate lang item error, so replace those by importing `minicore` completely.

rustbot added A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 25, 2025

rustbot assigned Mark-Simulacrum Dec 25, 2025