time-skipping refinements of propagation and describe - #11259
Closed
feiyang3cat wants to merge 21 commits into
Closed
time-skipping refinements of propagation and describe#11259feiyang3cat wants to merge 21 commits into
feiyang3cat wants to merge 21 commits into
Conversation
) 1. add virtual time and running status in DescribeWorkflowExecution 2. rename TimeSkippingEnabled to WorkflowTimeSkippingEnabled 3. add default implementation of new API - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s)
…to calculate notification status, allow false-positive
feiyang3cat
force-pushed
the
vts-refinements
branch
from
July 24, 2026 01:05
d5c4829 to
2f754d2
Compare
feiyang3cat
force-pushed
the
vts-refinements
branch
from
July 24, 2026 20:42
0f79ce2 to
e48d055
Compare
This was referenced Jul 24, 2026
feiyang3cat
force-pushed
the
vts-refinements
branch
from
July 25, 2026 20:40
7595f27 to
bb59cae
Compare
This was referenced Jul 25, 2026
feiyang3cat
force-pushed
the
vts-refinements
branch
3 times, most recently
from
July 26, 2026 02:04
61a1313 to
2f62972
Compare
feiyang3cat
commented
Jul 26, 2026
| if _, ok := updateFields["timeSkippingConfig"]; ok { | ||
| mergeInto.TimeSkippingConfig = mergeFrom.GetTimeSkippingConfig() | ||
| if mergeFrom.GetTimeSkippingConfig().GetFastForward() != nil { | ||
| if mergeFrom.GetTimeSkippingConfig().GetFastForwardConfig() != nil { |
Contributor
Author
There was a problem hiding this comment.
rebase vts-polling-ffid
feiyang3cat
commented
Jul 26, 2026
| if propagatedTargetTime != nil { | ||
| targetTime = propagatedTargetTime.AsTime() | ||
| // A propagated target may already be due; a due target is a completed fast-forward. | ||
| hasReached = !ms.Now().Before(targetTime) |
Contributor
Author
There was a problem hiding this comment.
flip enabled status
feiyang3cat
force-pushed
the
vts-refinements
branch
3 times, most recently
from
July 27, 2026 18:59
af19191 to
69b3a5f
Compare
feiyang3cat
force-pushed
the
vts-refinements
branch
14 times, most recently
from
July 28, 2026 04:24
ff78cc9 to
608c2cf
Compare
add archetypeID to notifier; always check ffid first; add quota; add polling mechanism, simplify result enum,
Squash of the vts-refinements work onto vts-polling-ffid, reconciled to polling-ffid's go.temporal.io/api version (nested FastForwardConfig, TimeSkippingInfo without IsRunning) and its fast_forward_id validation. Net change is confined to timeskipping.go and its test, since the two branches had converged elsewhere: - applyFastForward: gate on FastForwardConfig presence, compute HasReached for propagated targets, and only schedule the timer when the target is pending and skipping is enabled. - propagateTimeSkippingToNextRun: propagate config regardless of enabled/running state and forward the fast-forward target time (incl. stale/completed) so readers on the next run see full info. - GateByFastForward: handle a stale (already-due) fast-forward target. - describe/poll: map fast-forward info via ToFastForwardInfo (EffectiveConfig + FastForwardInfo, FastForwardDuration populated).
… long as propagation is not disabled
…ecution, and simplify it
feiyang3cat
force-pushed
the
vts-refinements
branch
from
July 30, 2026 02:43
608c2cf to
6da9a02
Compare
feiyang3cat
force-pushed
the
fx/vts-descrip-poll-maxskip
branch
4 times, most recently
from
July 30, 2026 21:09
93a35f8 to
5db0ac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
DescribeWorkflowExecutionso that users can check the time skipping runtime status in case they need itinitTimeSkippingInfoandTimeSkippingTransition.GateFastForward