Skip to content

flow/rtl: relax NumFlows constraints from 2 to 1 where applicable#930

Merged
mgottscho merged 6 commits intomainfrom
mgottscho/2025-11-12-num-flows
Dec 8, 2025
Merged

flow/rtl: relax NumFlows constraints from 2 to 1 where applicable#930
mgottscho merged 6 commits intomainfrom
mgottscho/2025-11-12-num-flows

Conversation

@mgottscho
Copy link
Copy Markdown
Contributor

No description provided.

@mgottscho mgottscho self-assigned this Nov 13, 2025
@mgottscho mgottscho marked this pull request as ready for review November 13, 2025 19:14
@mgottscho mgottscho enabled auto-merge (squash) November 13, 2025 19:15
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@masai-openai
Copy link
Copy Markdown
Contributor

masai-openai commented Nov 14, 2025

when NumFlows = 1, these cover/assertion precondition become unreachable. please add generate to exclude.

  1. br_flow_demux_select_unstable.gen_select_checks.gen_select_instability_cover.select_unstable_c
  2. br_flow_demux_select_unstable.gen_stable_push_valid.gen_pop_unstable_checks[0].pop_valid_instability_caused_by_select_a:precondition1
  3. br_flow_fork_select_multihot.gen_cover_select_multihot.select_multihot_c
  4. br_flow_mux_fixed.monitor.fv_checker.gen_pop_backpressure.gen_pop_data_unstable.pop_data_unstable_c
  5. br_flow_mux_select_unstable.gen_select_checks.gen_unstable_select.select_unstable_c
  6. br_flow_mux_select_unstable.gen_stable_push_valid_unstable_select.pop_valid_instability_caused_by_select_a:precondition1
  7. br_flow_mux_select_unstable.gen_stable_push_valid_unstable_select.gen_stable_push_data.pop_data_instability_caused_by_select_a:precondition1
  8. br_flow_mux_select_unstable.monitor.fv_checker.gen_pop_backpressure.gen_pop_data_unstable.pop_data_unstable_c
  9. br_flow_xbar_core_inst.gen_demux[0].br_flow_demux_select_unstable_push.gen_select_checks.gen_select_instability_cover.select_unstable_c
  10. br_flow_xbar_core_inst.gen_demux[0].br_flow_demux_select_unstable_push.gen_stable_push_valid.gen_pop_unstable_checks[0].pop_valid_instability_caused_by_select_a:precondition1

@mgottscho
Copy link
Copy Markdown
Contributor Author

when NumFlows = 1, these cover/assertion precondition become unreachable. please add generate to exclude.

  1. br_flow_demux_select_unstable.gen_select_checks.gen_select_instability_cover.select_unstable_c
  2. br_flow_demux_select_unstable.gen_stable_push_valid.gen_pop_unstable_checks[0].pop_valid_instability_caused_by_select_a:precondition1
  3. br_flow_fork_select_multihot.gen_cover_select_multihot.select_multihot_c
  4. br_flow_mux_fixed.monitor.fv_checker.gen_pop_backpressure.gen_pop_data_unstable.pop_data_unstable_c
  5. br_flow_mux_select_unstable.gen_select_checks.gen_unstable_select.select_unstable_c
  6. br_flow_mux_select_unstable.gen_stable_push_valid_unstable_select.pop_valid_instability_caused_by_select_a:precondition1
  7. br_flow_mux_select_unstable.gen_stable_push_valid_unstable_select.gen_stable_push_data.pop_data_instability_caused_by_select_a:precondition1
  8. br_flow_mux_select_unstable.monitor.fv_checker.gen_pop_backpressure.gen_pop_data_unstable.pop_data_unstable_c
  9. br_flow_xbar_core_inst.gen_demux[0].br_flow_demux_select_unstable_push.gen_select_checks.gen_select_instability_cover.select_unstable_c
  10. br_flow_xbar_core_inst.gen_demux[0].br_flow_demux_select_unstable_push.gen_stable_push_valid.gen_pop_unstable_checks[0].pop_valid_instability_caused_by_select_a:precondition1

Thanks! I think most of these will go away if I finish and merge #936 first.

@mgottscho mgottscho merged commit cafcb0e into main Dec 8, 2025
17 checks passed
@mgottscho mgottscho deleted the mgottscho/2025-11-12-num-flows branch December 8, 2025 16:09
masai-openai added a commit that referenced this pull request Dec 8, 2025
Update FPV after #930.
I have run all affected RTL, there are only unreachable covers.
All unreachable covers are reported in PR930, which will be addressed in
future PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants