Conversation
mgottscho
commented
Nov 14, 2025
mgottscho
commented
Jan 23, 2026
| @@ -228,8 +228,8 @@ br_verilog_fpv_test_tools_suite( | |||
| illegal_param_combinations = { | |||
| ( | |||
Contributor
Author
There was a problem hiding this comment.
[written by codex]
These FPV suites still list EnableAssertSelectStability, but the select monitor params were renamed to EnableAssumeSelectStability. This will try to set a non-existent parameter for mux-select monitors. Can you rename this (and the other occurrence in this file) to EnableAssumeSelectStability?
Contributor
Author
There was a problem hiding this comment.
OMG CODEX IT WORKED
mgottscho
commented
Jan 23, 2026
| "EnableAssertPushDataStability", | ||
| "EnableAssumePushValidStability", | ||
| "EnableAssumePushDataStability", | ||
| "EnableAssertSelectStability", |
Contributor
Author
There was a problem hiding this comment.
[written by codex]
Same issue here: the monitor param is now EnableAssumeSelectStability, but the BUILD suite still uses EnableAssertSelectStability. Please rename this (and the other occurrence below) so the test tools pass valid params.
Contributor
Author
There was a problem hiding this comment.
OMG CODEX IT WORKED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.