-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Version 1.14 #84
base: 1_14_4
Are you sure you want to change the base?
Conversation
修改plugin.yml
修改Plugin.yml 修改out file name
I am not going to pull this into RaspberryJuice. Let me explain why and offer some thoughts on next steps. I am preparing a new release of RaspberryJuice based on Bukkit 1.12.2 which brings in some older outstanding PRs. I think this will be the last release of RaspberryJuice The change to minecraft's data model replacing integer ids with strings means that any version based on 1.13+ will no longer be compatible with programs made against previous versions or any program written to run on Minecraft: Pi edition. It feels like time for RaspberryJuice2. A separate plugin which makes a clear distinction about the break in compatibility and takes forward the premise of a real-time Minecraft API. My motivations for maintaining RaspberryJuice are to ensure its compatibility with the Pi edition and I dont feel like I am the right person to take this forward. @MinecraftDawn if you want to take forward a RaspberryJuice2 I will happily link to the new plugin for this repo, the bukkit and spigot pages, offering RaspberryJuice2 as the natural successor. |
Great pull request by @MinecraftDawn - i hope we see a v1.14 compatible fork under a new name. |
I agree. |
Isn't really possible to map previous integer ids to new strings ? I suppose that not all new blocks and entities could be mapped this way, but at least all previous from 1.12 seems possible. Am I wrong? I agree that previous samples with integer ids should still work, but this does not eliminate to move forward to 1.14. We should eat cake and still have it. |
Thanks for your explanation and review my codes. Maybe i will map integer id to new string id. |
Any news on this movement to RaspberryJuice2? @MinecraftDawn ? After some time working with Minecraft and Python, I have reached this point in which this wonderful API (Raspberry PI) is in dangerous after 7 years. For me all has worked yet in the current state (MC 1.15.2 with Spigot, RaspeberryJuice 1.11 and 1.12). Spingot 1.15.2 has the legacy material layer, so the plugin works nicely with mcpi because this layer is converting from block ids to material string in both directions (python/mcpi <-> plugin <-> legacy material <-> minecraft server). My experience during the last months is that I can use this Raspberry PI in Minecraft and also in Minetest, and it is great as a bridge between both communities. And also, the possibilities of this API are wonderful. I have developed McThings (https://github.com/juntosdesdecasa/mcthings) based on it supporting for example Schematics, McDrawings and others using this Raspberry PI API. Thinking in the current position, at least in my mind, the process to evolve should be something like:
I am thinking also in a solution for the Forge plugin (stopped also at 1.12.2 version) and the Minetest plugin (which is working now and it has no problems with its Lua implementation). Atter reading the code for the Legacy Material (in CraftBukkit) the vanilla server has a nice support for this conversion between blocks ids and material strings, so a solid solution could be reached. With the Legacy Material we are now covered (1.11 and 1.12 version of the plugin are working with 1.15.2 Spigot MC server) but this layer introduces latency and limits the blocks that can be used (maybe this is something we want to respect the original API). And the motivation for maintaining it will decrease as plugins migrate to material strings. Any thoughts about all of that are more than welcome. I am pretty motivated now to evolve the current code (Python and Java, I have experience programming with both). |
I have tested the PR and it works. And I have created a block using the string "bedrock" instead of the legacy bedrock id. |
I'm inclined to create a fork of RaspberryJuice with the pull requst by @MinecraftDawn under the new name RaspberryJellyBut only if noone else is willing to do it! 😁 I don't know how much time i can invest into keeping it updated so I'm counting on contributions by others. |
Please take a look at https://github.com/wensheng/JuicyRaspberryPie It's initially based on raspberryjuice, but now offer a lot more. |
Thanks for pointing it out. Could you clarify the situation in the README and link to that related project? |
@martinohanlon maybe it could be worth to consider if some parts of this branch could be commited into master. Old API still works, and maybe it's time to extend it (not replace) to support new block naming convention too? |
@MinecraftDawn, please let us know how we can help? It looks like there's currently 196 files changed in this branch. Re your question @martinohanlon, have you looked into what would be involved to making it a feature-flag? |
@lukebrowell My views haven't changed. I don't think progressing this is the right choice for RaspberryJuice. I will happily promote any new version of RaspberryJuice though but it would be a new plugin not a continuation. |
Totally understand. My, is it fork o’clock already? How time flys. Thanks for the chat, but I must be on my way. Toodle-oo |
I'm not good at english,so maybe hava many grammar error
You can decide whether to use any part of this pull