Repository navigation
refactor: use suite actions instead of pre-consolidation repos - #48
Merged
Merged
Conversation
oc-runner and deployer call bcgov/actions/diff-triggers v0.8.0 instead of bcgov/action-diff-triggers (deployer: github_token -> token), and deployer calls the sibling $/oc-runner instead of bcgov/action-oc-runner. crunchy is left alone; .deployer.yml keeps action-get-pr (no suite equivalent).
This was referenced Sep 27, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The pinned versions, inputs, outputs, and sibling-action references are compatible with existing behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Migrates OpenShift actions from legacy repositories to consolidated suite actions.
Changes:
- Uses the suite’s pinned
diff-triggersaction and updatedtokeninput. - Makes deployer use the sibling suite
oc-runner.
| File | Description |
|---|---|
oc-runner/action.yml |
Migrates diff-trigger dependency. |
deployer/action.yml |
Migrates diff-trigger and oc-runner dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops oc-runner and deployer depending on the pre-consolidation repos, so those repos can be archived without the suite relying on them.
oc-runner/action.yml,deployer/action.yml:bcgov/action-diff-triggers@v1.2.1→bcgov/actions/diff-triggers@4026bfd(v0.8.0).github_tokenis nowtoken(deployer's only change at the call site).triggers,refand thetriggeredoutput are unchanged.actions/checkoutitself. The suite one clones only when the workspace has no git repo. Both callers check out the target repo through oc-runner right after the diff step, so the files later steps need are still there.deployer/action.yml:bcgov/action-oc-runner@v1.7.0→$/oc-runner. This is the repo's convention for calling a sibling action (as route-tls, cleanup-pr and.deployer.ymlalready do), so deployer runs the oc-runner from the same suite release. Every input deployer passes exists in the suite oc-runner with the same meaning. One behaviour change: the suite oc-runner limitscommandswith itstimeoutinput, but deployer passes nocommands..github/workflows/.deployer.yml:bcgov/action-get-pr@v0.3.1is left as is. bcgov/actions has no drop-in replacement: image-tracker only returns a PR number as part of resolving images for packages.crunchy/is intentionally untouched.Some README text still names the old repos (
cleanup-pr/README.md,route-tls/README.md,deployer/README.mdbadges and a deprecation note). These are docs only, not dependencies, so they're not changed here.