Clamp SpotLight.outer_angle to pi/2-epsilon at extraction time#24734
Open
dylansechet wants to merge 2 commits into
Open
Clamp SpotLight.outer_angle to pi/2-epsilon at extraction time#24734dylansechet wants to merge 2 commits into
SpotLight.outer_angle to pi/2-epsilon at extraction time#24734dylansechet wants to merge 2 commits into
Conversation
dylansechet
commented
Jun 23, 2026
| Spot lights require `outer_angle < π/2`", | ||
| outer_angle | ||
| ); | ||
| outer_angle = core::f32::consts::FRAC_PI_2 - 1e-4; |
Contributor
Author
There was a problem hiding this comment.
The 1e-4 is completely arbitrary
kfc35
added
C-Bug
kfc35
approved these changes
Jun 24, 2026
| /// Angle defining the distance from the spot light direction to the outer limit | ||
| /// of the light's cone of effect. | ||
| /// `outer_angle` should be < `PI / 2.0`. | ||
| /// `PI / 2.0` defines a hemispherical spot light, but shadows become very blocky as the angle |
Contributor
There was a problem hiding this comment.
Is this not true anymore? Just wondering the reason for the removal
Contributor
Author
There was a problem hiding this comment.
I feel like publicly documenting the behavior of an unsupported value sends a confusing message. To me this read as "pi/2 is possible, with the only downside that you might get weird shadows".
kfc35
added
the
D-Straightforward
JMS55
approved these changes
Jun 24, 2026
JMS55
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The documentation currently recommends
SpotLight.outer_anglestay <pi/2, but doesn't enforce it anywhere.SpotLight.outer_angle = pi/2is fundamentally broken, notably causing issues with gpu light clustering.This fixes #24721.
Solution
Clamp
outer_angletopi/2 - epsilonat extraction time and warn the user if it's out of range.Testing
Tested the scene from #24721.