Conversation
GiulioRomualdi
force-pushed
the
add_calibrated_skin
branch
2 times, most recently
from
c311614 to
7ffdb67
Compare
GiulioRomualdi
force-pushed
the
add_calibrated_skin
branch
from
7ffdb67 to
e1019a7
Compare
GiulioRomualdi
force-pushed
the
add_calibrated_skin
branch
from
e1019a7 to
c33ecc7
Compare
- This is required by frugally-deep
| # in case a calibration phase necessary before starting teleoperating the robot, | ||
| # otherwise read the calibration matrix from the config file | ||
| doCalibration 1 | ||
| doCalibration 0 |
There was a problem hiding this comment.
Do you remember why this change is needed? (@RiccardoGrieco @lrapetti)
| axesJointsCoupled 1 | ||
|
|
||
| doCalibration 1 | ||
| doCalibration 0 |
|
|
||
| bool GloveWearableImpl::setFingertipForceFeedbackValues(const std::vector<int>& values) | ||
| { | ||
| return true; |
There was a problem hiding this comment.
As discussed F2F, it would be nice to have a parameter to turn this on and off, rather than exiting prematurely. @RiccardoGrieco @lrapetti do you remember why this was needed?
|
|
||
| bool GloveWearableImpl::setFingertipVibrotactileValues(const std::vector<int>& values) | ||
| { | ||
| return true; |
| m_Bias = Eigen::MatrixXd::Zero(m_numActuatedJoints, 1); | ||
|
|
||
| if (!m_doCalibration) | ||
| if (false && !m_doCalibration) |
There was a problem hiding this comment.
Probably this false can be removed. @RiccardoGrieco @lrapetti, do you remember why it was needed?
GiulioRomualdi
force-pushed
the
add_calibrated_skin
branch
from
f205640 to
20c6c86
Compare
|
The CI is failing but @S-Dafarra already fixed it in #118. I would merge the PR even if the CI fails and then rebase frugally_rebased on top of master |
|
If you prefer, we can merge this as is and apply the comments above in |
|
This would simplify the merging procedure :) Let me apply #114 (comment) |
…kin.cpp Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
3 participants
Thanks to this PR it will be possible to use the calibrated skin provided by the skin manager to detect the roughness of an object.
The network model was provided at c33ecc7. The code used to generate the model can be found in paolo-viceconte/rock_classifier@381fcf4 (@paolo-viceconte)
Moreover this PR remove the fingertip actuation (@RiccardoGrieco) in 63aff82
Last but not least fixes the CI