-
Notifications
You must be signed in to change notification settings - Fork 15
Add calibrated skin #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add calibrated skin #114
Changes from all commits
ec080e7
c33ecc7
8324e6a
add807d
63aff82
e0307c9
9822b6b
e799ac9
85fd59c
20c6c86
cae1ed3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -145,7 +145,7 @@ analog_sensors_raw_max_boundary ( 25.0 0.0 37.0 15.0 24.0 12.0 0.0 | |
| # in case each joint does not have independant motor to actuate, they are coupled | ||
| axesJointsCoupled 1 | ||
|
|
||
| doCalibration 1 | ||
| doCalibration 0 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above |
||
|
|
||
| #robot controller exponential filter gain | ||
| exponentialFilterGain 0.9 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -334,6 +334,7 @@ bool GloveWearableImpl::getFingertipPoseValues(Eigen::MatrixXd& values) | |
|
|
||
| bool GloveWearableImpl::setFingertipForceFeedbackValues(const std::vector<int>& values) | ||
| { | ||
| return true; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As discussed F2F, it would be nice to have a parameter to turn this on and off, rather than exiting prematurely. @RiccardoGrieco @lrapetti do you remember why this was needed? |
||
| if (values.size() != m_numForceFeedback) | ||
| { | ||
| yError() << m_logPrefix | ||
|
|
@@ -362,6 +363,7 @@ bool GloveWearableImpl::setFingertipForceFeedbackValues(const std::vector<int>& | |
|
|
||
| bool GloveWearableImpl::setFingertipVibrotactileValues(const std::vector<int>& values) | ||
| { | ||
| return true; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above |
||
| if (values.size() != m_numVibrotactileFeedback) | ||
| { | ||
| yError() | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,10 +62,10 @@ bool RobotController::configure(const yarp::os::Searchable& config, | |
|
|
||
| if (m_axesJointsCoupled) | ||
| { | ||
| m_A.resize(m_numActuatedJoints, m_numActuatedAxis); | ||
| m_Bias.resize(m_numActuatedJoints, 1); | ||
| m_A = Eigen::MatrixXd::Identity(m_numActuatedAxis, m_numActuatedAxis); | ||
| m_Bias = Eigen::MatrixXd::Zero(m_numActuatedJoints, 1); | ||
|
|
||
| if (!m_doCalibration) | ||
| if (false && !m_doCalibration) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably this |
||
| { | ||
| if (m_numActuatedAxis != m_numAllAxis && m_numActuatedJoints != m_numAllJoints) | ||
| { | ||
|
|
@@ -77,8 +77,7 @@ bool RobotController::configure(const yarp::os::Searchable& config, | |
| return false; | ||
| } | ||
| std::vector<double> A_vector, Bias_vector; | ||
| A_vector.resize(m_numActuatedJoints * m_numActuatedAxis); | ||
| Bias_vector.resize(m_numActuatedJoints); | ||
|
|
||
| if (!YarpHelper::getVectorFromSearchable(config, "CouplingMatrix", A_vector)) | ||
| { | ||
| yError() << m_logPrefix | ||
|
|
@@ -117,11 +116,6 @@ bool RobotController::configure(const yarp::os::Searchable& config, | |
| m_Bias(i) = Bias_vector[i]; | ||
| } | ||
| } | ||
| } else | ||
| { | ||
| // if not coupled., the mapping between the motors and joints are identity matrix | ||
| m_A = Eigen::MatrixXd::Identity(m_numActuatedAxis, m_numActuatedAxis); | ||
| m_Bias = Eigen::MatrixXd::Zero(m_numActuatedJoints, 1); | ||
| } | ||
|
|
||
| // get control gains from configuration files | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you remember why this change is needed? (@RiccardoGrieco @lrapetti)