-
Notifications
You must be signed in to change notification settings - Fork 3
✨ move keepalived here from BMO repo #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b3b5153 to
3b0d749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to bring in the image building workflow as well, as well as parts of release workflow, and parts of release documentation too.
3b0d749 to
059e134
Compare
307ec43 to
fd9e677
Compare
|
What is left to discuss with the community what release tags to use in the future for keepalived, as right now I don't see any reason to follow BMO releases/ release tags for keepalived. The other PR that removes keepalived from BMO is also in progress. I would also suggest doing a release of keepalived after this PR has been merged, as part of the release we would test whether everything works as expected and I would suggest choosing a release tag that is detached from BMO. |
fd9e677 to
eba8b63
Compare
No, we should release keepalived when there is relevant changes.
👍
Absolutely. As we did with ironic-client, it is also good time to give it some attention, bump anything there is to bump etc, then release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
The release process needs to be agreed and then all the automation/docs adapted to match.
|
As discussed offline, let's split this into three PRs:
This keeps the changes clean and testable, and also we don't need release logic until there is something new to release, like the read-only changes. Adapting the current release automation without branch support needs to be implemented carefully and generic enough so we can port that over to mariadb and other repos where we do similar lightweight releases going forward. |
3a73700 to
65285fd
Compare
|
Release related stuff has been reoved from this PR, |
This commit: - Moves the project used to build the Metal3 keepalived container from the BMO repository to this repository These changes were needed for two related reasons. - The community has decided that there is no reason to keep the keepalived files in BMO and they much better fit for the utility-images repository. Signed-off-by: Adam Rozman <adam.rozman@est.tech>
|
After discussing offline a more about this comment metal3-io/baremetal-operator#2279 (review) I have made the decision to act accordingly so now this PR only moves keepalived here and I will make addition PRs to implement the RO-FS support here and not in the BMO repo or as part of the move process so that we will have a cleaner history. @tuminoid |
|
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR:
the BMO repository to this repository
These changes were needed for two related reasons.
files in BMO and they much better fit for the utility-images repository.
Related issues: