Skip to content

Conversation

@Rozzii
Copy link
Member

@Rozzii Rozzii commented Jan 31, 2025

This PR:

  • Moves the project used to build the Metal3 keepalived container from
    the BMO repository to this repository

These changes were needed for two related reasons.

  • The community has decided that there is no reason to keep the keepalived
    files in BMO and they much better fit for the utility-images repository.

Related issues:

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2025
@Rozzii Rozzii force-pushed the keepalived_move branch 2 times, most recently from b3b5153 to 3b0d749 Compare January 31, 2025 12:17
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bring in the image building workflow as well, as well as parts of release workflow, and parts of release documentation too.

@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2025
@Rozzii Rozzii force-pushed the keepalived_move branch 3 times, most recently from 307ec43 to fd9e677 Compare January 31, 2025 13:32
@Rozzii
Copy link
Member Author

Rozzii commented Jan 31, 2025

What is left to discuss with the community what release tags to use in the future for keepalived, as right now I don't see any reason to follow BMO releases/ release tags for keepalived.

The other PR that removes keepalived from BMO is also in progress.

I would also suggest doing a release of keepalived after this PR has been merged, as part of the release we would test whether everything works as expected and I would suggest choosing a release tag that is detached from BMO.

@tuminoid
Copy link
Member

What is left to discuss with the community what release tags to use in the future for keepalived, as right now I don't see any reason to follow BMO releases/ release tags for keepalived.

No, we should release keepalived when there is relevant changes.

The other PR that removes keepalived from BMO is also in progress.

👍

I would also suggest doing a release of keepalived after this PR has been merged, as part of the release we would test whether everything works as expected and I would suggest choosing a release tag that is detached from BMO.

Absolutely. As we did with ironic-client, it is also good time to give it some attention, bump anything there is to bump etc, then release.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

The release process needs to be agreed and then all the automation/docs adapted to match.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2025
@tuminoid
Copy link
Member

As discussed offline, let's split this into three PRs:

  1. clean move PR, no modifications except necessary paths etc
  2. add the functionality/changes required for the read-only filesystem improvement
  3. add release logic separately (but keep the basic image build workflow)

This keeps the changes clean and testable, and also we don't need release logic until there is something new to release, like the read-only changes. Adapting the current release automation without branch support needs to be implemented carefully and generic enough so we can port that over to mariadb and other repos where we do similar lightweight releases going forward.

@Rozzii Rozzii force-pushed the keepalived_move branch 6 times, most recently from 3a73700 to 65285fd Compare March 5, 2025 12:20
@Rozzii
Copy link
Member Author

Rozzii commented Mar 5, 2025

Release related stuff has been reoved from this PR,
Read only support is handled by BMO PR: metal3-io/baremetal-operator#2279
After the above mentioned PR has been merged this PR can be merged also.

This commit:
 - Moves the project used to build the Metal3 keepalived container from
   the BMO repository to this repository

These changes were needed for two related reasons.
 - The community has decided that there is no reason to keep the keepalived
   files in BMO and they much better fit for the utility-images repository.

Signed-off-by: Adam Rozman <adam.rozman@est.tech>
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2025
@Rozzii Rozzii changed the title move keepalived here from BMO repo ✨ move keepalived here from BMO repo Mar 27, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Mar 27, 2025

After discussing offline a more about this comment metal3-io/baremetal-operator#2279 (review) I have made the decision to act accordingly so now this PR only moves keepalived here and I will make addition PRs to implement the RO-FS support here and not in the BMO repo or as part of the move process so that we will have a cleaner history. @tuminoid

@Rozzii Rozzii requested a review from tuminoid March 27, 2025 13:09
@Rozzii
Copy link
Member Author

Rozzii commented Mar 27, 2025

/hold cancel
Reason is explained above .

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2025
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025
@kashifest
Copy link
Member

/approve

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
@metal3-io-bot metal3-io-bot merged commit ca9951f into metal3-io:main Mar 28, 2025
6 of 7 checks passed
@metal3-io-bot metal3-io-bot deleted the keepalived_move branch March 28, 2025 11:17
@lentzi90 lentzi90 moved this from Ironic-image WIP to Done / Closed in Metal3 - Roadmap Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Done / Closed

Development

Successfully merging this pull request may close these issues.

None yet

5 participants