Frontend map submission form #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
added
the
For: Frontend
|
Again CI is failing, mostly easy stuff but no idea why esbuild is failing in CI. Can still review now, I'll get CI fixed in next few days, just wanna do some actual dev work for rest of today. |
tsa96
force-pushed
the
feat/frontend-map-submission-1
branch
5 times, most recently
from
dbd90ac to
0b69038
Compare
tsa96
force-pushed
the
feat/frontend-map-submission-1
branch
from
0b69038 to
ea17e1f
Compare
I just can't see a good use for these fields in our UI, we never show when someone e.g. last updates their profile. Also there's overlap with the two tables. Not worth keeping IMO
Yeah this is slightly longer but whatever, I want to keep naming consistent.
I just don't like it
`npm install` shifts stuff around if ordered wrong
This is messy but we'll get all our styling cleaned up soon when Nebular is gone
This is getting bundled by ESBuild, or something. I need to look into this more tbh, but for this brand it works and is fine
Why tf did they still have this lmao
This will move to the new component when I rework the map edit page, but haven't started on that yet.
…at are mutually incompatible The
Improves styling and backend requests
I love it when I get to work on fun stuff for once
Since this is essentially rewriting the whole thing, this is probably a lot easier to review if I delete everything then commit new stuff in chunks.
What's nice is how little code in the form component this actually requires - our custom upload component and validators do practically all the work.
The leaderboards component will be reused in map edit form
This imported a Nest thing into a shared library, so was getting bundling by the frontend - not good!
tsa96
force-pushed
the
feat/frontend-map-submission-1
branch
from
ea17e1f to
01be592
Compare
Gocnak
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page isn't totally finished, but I've largely moved away from it in the last week as I've worked on broader frontend refactoring, and further map submission stuff. Didn't want to leave this sitting around, so let's get this in.
The info text can get finalized soon, ideally after a meeting where people can proof what I write. All the styling will be finalized once Nebular is finally gone.
Based on top of #867, please review that first.
Closes #603