Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure flow over plate #154

Merged
merged 17 commits into from
Mar 10, 2021

Conversation

davidscn
Copy link
Member

@davidscn davidscn commented Feb 14, 2021

Closes #136

Open TODOs:

@IshaanDesai
Copy link
Member

Could you please try the CalculiX combination with the branch of the CalculiX-Adapter in this PR: precice/calculix-adapter#50? If CalculiX still crashes then the error message would be helpful in determining the problem.

@davidscn
Copy link
Member Author

Already done. CalculiX crashes here https://github.com/precice/calculix-adapter/blob/63af15333c8d5f3ba85fdec28ec35042cb2691e2/nonlingeo_precice.c#L1307 since the simulationData(?) is uninitialized.

@davidscn davidscn linked an issue Feb 15, 2021 that may be closed by this pull request
@davidscn davidscn requested a review from uekerman March 2, 2021 09:13
@davidscn
Copy link
Member Author

davidscn commented Mar 2, 2021

Ready to merge!

Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully ran FEniCS-OpenFOAM, Nutils-OpenFOAM and OpenFOAM-OpenFOAM.

Minor documentation issues.

I think you should also add some more files to the .gitignore, since I currently get quite a lot of untracked files due to output:

$ ~/tutorials/flow-over-heated-plate$ git status .
HEAD detached at DavidSCN/restructure-flow-over-plate
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   precice-config.xml

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	buoyantPimpleFoam-fenics/
	fluid-openfoam/0.2/
	fluid-openfoam/0.4/
	fluid-openfoam/0.6/
	fluid-openfoam/0.8/
	fluid-openfoam/0/
	fluid-openfoam/1/
	fluid-openfoam/VTK/
	fluid-openfoam/constant/polyMesh/
	fluid-openfoam/precice-Fluid-events-summary.log
	fluid-openfoam/precice-Fluid-events.json
	fluid-openfoam/precice-Fluid-iterations.log
	solid-fenics/Solid/
	solid-fenics/precice-Solid-convergence.log
	solid-fenics/precice-Solid-events-summary.log
	solid-fenics/precice-Solid-events.json
	solid-fenics/precice-Solid-iterations.log
	solid-nutils/Solid_0.vtk
	solid-nutils/Solid_100.vtk
	solid-nutils/Solid_20.vtk
	solid-nutils/Solid_40.vtk
	solid-nutils/Solid_60.vtk
	solid-nutils/Solid_80.vtk
	solid-nutils/precice-Solid-convergence.log
	solid-nutils/precice-Solid-events-summary.log
	solid-nutils/precice-Solid-events.json
	solid-nutils/precice-Solid-iterations.log
	solid-openfoam/0.2/
	solid-openfoam/0.4/
	solid-openfoam/0.6/
	solid-openfoam/0.8/
	solid-openfoam/0/
	solid-openfoam/1/
	solid-openfoam/constant/polyMesh/
	solid-openfoam/precice-Solid-convergence.log
	solid-openfoam/precice-Solid-events-summary.log
	solid-openfoam/precice-Solid-events.json
	solid-openfoam/precice-Solid-iterations.log

@davidscn
Copy link
Member Author

davidscn commented Mar 8, 2021

Thanks!

I think you should also add some more files to the .gitignore, since I currently get quite a lot of untracked files due to output:

I understand. This is more a developer problem and not a user problem. I usually use the clean scripts to get rid of these outputs, but this might not always be what you want. However, I would vote for a global gitignore file since we have similar problems in all tutorials cases and I don't like the duplication. Reminds me of #133 and couldbe part of the workpackage there.

Apart from that, ready to merge.

@davidscn
Copy link
Member Author

davidscn commented Mar 10, 2021

@BenjaminRodenberg I checked now the parameters of your figure again. The farfield velocity should be 0.1 instead of 0.01 and (maybe) the gravity needs a minus sign. I would also remove the z coordinate: you don't have it in the figure and it hasn't any relevance for this case. The heat transfer coefficient k is only defined in the solid participant/ I cannot find it in the Fluid preciceDict, is this correct?

Do you want to comment on the .gitignore discussion?

@davidscn davidscn mentioned this pull request Mar 10, 2021
2 tasks
@BenjaminRodenberg
Copy link
Member

Do you want to comment on the .gitignore discussion?

A global .gitignore is also fine 👍

@BenjaminRodenberg BenjaminRodenberg self-requested a review March 10, 2021 16:05
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@davidscn davidscn merged commit 3ddf707 into precice:restructure Mar 10, 2021
@davidscn davidscn deleted the restructure-flow-over-plate branch March 10, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatten solver hierarchy for flow-over-heated-plate
4 participants