-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure flow over plate #154
Restructure flow over plate #154
Conversation
Could you please try the CalculiX combination with the branch of the CalculiX-Adapter in this PR: precice/calculix-adapter#50? If CalculiX still crashes then the error message would be helpful in determining the problem. |
Already done. CalculiX crashes here https://github.com/precice/calculix-adapter/blob/63af15333c8d5f3ba85fdec28ec35042cb2691e2/nonlingeo_precice.c#L1307 since the simulationData(?) is uninitialized. |
Ready to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I successfully ran FEniCS-OpenFOAM, Nutils-OpenFOAM and OpenFOAM-OpenFOAM.
Minor documentation issues.
I think you should also add some more files to the .gitignore
, since I currently get quite a lot of untracked files due to output:
$ ~/tutorials/flow-over-heated-plate$ git status .
HEAD detached at DavidSCN/restructure-flow-over-plate
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: precice-config.xml
Untracked files:
(use "git add <file>..." to include in what will be committed)
buoyantPimpleFoam-fenics/
fluid-openfoam/0.2/
fluid-openfoam/0.4/
fluid-openfoam/0.6/
fluid-openfoam/0.8/
fluid-openfoam/0/
fluid-openfoam/1/
fluid-openfoam/VTK/
fluid-openfoam/constant/polyMesh/
fluid-openfoam/precice-Fluid-events-summary.log
fluid-openfoam/precice-Fluid-events.json
fluid-openfoam/precice-Fluid-iterations.log
solid-fenics/Solid/
solid-fenics/precice-Solid-convergence.log
solid-fenics/precice-Solid-events-summary.log
solid-fenics/precice-Solid-events.json
solid-fenics/precice-Solid-iterations.log
solid-nutils/Solid_0.vtk
solid-nutils/Solid_100.vtk
solid-nutils/Solid_20.vtk
solid-nutils/Solid_40.vtk
solid-nutils/Solid_60.vtk
solid-nutils/Solid_80.vtk
solid-nutils/precice-Solid-convergence.log
solid-nutils/precice-Solid-events-summary.log
solid-nutils/precice-Solid-events.json
solid-nutils/precice-Solid-iterations.log
solid-openfoam/0.2/
solid-openfoam/0.4/
solid-openfoam/0.6/
solid-openfoam/0.8/
solid-openfoam/0/
solid-openfoam/1/
solid-openfoam/constant/polyMesh/
solid-openfoam/precice-Solid-convergence.log
solid-openfoam/precice-Solid-events-summary.log
solid-openfoam/precice-Solid-events.json
solid-openfoam/precice-Solid-iterations.log
Co-authored-by: Benjamin Rodenberg <[email protected]>
…orials into restructure-flow-over-plate
Thanks!
I understand. This is more a developer problem and not a user problem. I usually use the clean scripts to get rid of these outputs, but this might not always be what you want. However, I would vote for a global Apart from that, ready to merge. |
@BenjaminRodenberg I checked now the parameters of your figure again. The farfield velocity should be 0.1 instead of 0.01 and (maybe) the gravity needs a minus sign. I would also remove the z coordinate: you don't have it in the figure and it hasn't any relevance for this case. The heat transfer coefficient k is only defined in the solid participant/ I cannot find it in the Fluid preciceDict, is this correct? Do you want to comment on the |
A global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Closes #136
Open TODOs:
CalculiX crashes. Might be related to Add functionality to handle 2D interfaces calculix-adapter#49. Maybe @IshaanDesai knows more about it.Postponed to (Add CalculiX as a solid participant in flow-over-heated plate case #157)