Fix/disable swap on ios #19306
Open
Fix/disable swap on ios #19306
+43
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjba
requested review from
a team,
caybro,
micieslak and
noeliaSD
as code owners
Contributor
Author
|
@sunleos The swaps will be disabled for 2.36 release branch only. Please let me know if we need to permanently disable it on IOS (master branch). I hope it's not needed 😄 |
Member
Jenkins BuildsClick to see older builds (38)
|
Collaborator
Yes, it is OK to have it disabled just for 2.36 for now. |
Contributor
Contributor
Author
noeliaSD
approved these changes
Nov 19, 2025
Contributor
noeliaSD
left a comment
noeliaSD
left a comment
There was a problem hiding this comment.
LGTM!
- Tested on
ios simulator. - Tested on
desktop.
Contributor
Got it! I was thinking we wanted to keep this disabled state in master too. If it's just something for the release, then it points to the correct branch already! Thanks for clarification! |
caybro
approved these changes
Nov 19, 2025
Member
|
We still need this in master; everything except the physical setting of the flag for iOS ( |
alexjba
force-pushed
the
fix/disable-swap-ios
branch
2 times, most recently
from
ac40c67 to
5204a53
Compare
This was referenced Nov 20, 2025
Open
This was referenced Nov 21, 2025
The release pipeline was failing on the publish stage.
fixes `libusb` being busy when app is closed and started again. ``` starting pcscd with /tmp/.mount_StatusKDpnfI/usr/bin/pcscd -f & 00000000 [136864157226944] ccid_usb.c:672:OpenUSBByName() Can't claim interface 3/5: LIBUSB_ERROR_BUSY 00000172 [136864157226944] ifdhandler.c:160:CreateChannelByNameOrChannel() failed 00000003 [136864157226944] ../src/readerfactory.c:1132:RFInitializeReader() Open Port 0x200000 Failed (usb:058f/9540:libudev:0:/dev/bus/usb/003/005) 00000003 [136864157226944] ../src/readerfactory.c:371:RFAddReader() Alcor Micro AU9540 init failed. 00000043 [136864157226944] ../src/hotplug_libudev.c:517:HPAddDevice() Failed adding USB device: Alcor Micro AU9540 qt.core.qobject.connect: QObject::connect(QObject, Unknown): invalid nullptr parameter ``` https://man.freebsd.org/cgi/man.cgi?query=pcscd&sektion=8&manpath=freebsd-release-ports#end <img width="713" height="153" alt="Screenshot 2025-09-04 at 12 11 18 PM" src="https://github.com/user-attachments/assets/78aa1104-7791-4e6e-9a7f-391466b089d2" /> fixes: #18635
jrainville
force-pushed
the
fix/disable-swap-ios
branch
from
5204a53 to
49c6a0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Closes #19305
Disabling IOS swaps for this release.
The wallet tab was already hooked to the feature flags. The only missing piece was the market tab.
Affected areas
IOS - swap
Architecture compliance
How to test
Login and try to find the Swap buttons.
Risk
low