Skip to content

Conversation

@njooma
Copy link
Member

@njooma njooma commented Dec 17, 2025

RobotClient implements framesystem, so users don't actually need to call framesystem.FromProvider(machine). However, a user might find it confusing if they cannot use FromProvider like they can every where else. In the spirit of reducing the cognitive load and letting users get resources the same way across the board, calling framesystem.FromProvider on a RobotClient should return itself.

@njooma njooma requested review from a team, allisonschiang, nfranczak and stuqdog and removed request for a team December 17, 2025 22:46
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 17, 2025
@njooma njooma force-pushed the RSDK-12945/robot-client-frame-system branch from 28d9295 to 1c8eccc Compare December 23, 2025 16:59
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 23, 2025
@njooma njooma requested a review from a team January 5, 2026 16:36
@njooma njooma merged commit 20fdc23 into viamrobotics:main Jan 5, 2026
19 checks passed
@njooma njooma deleted the RSDK-12945/robot-client-frame-system branch January 5, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants