heuristic for estimating the number of non-zeros in constraint_jacobian#1241
Merged
thowell merged 3 commits intogoogle-deepmind:mainfrom Mar 24, 2026
Merged
Conversation
3 tasks
erikfrey
approved these changes
Mar 21, 2026
Collaborator
erikfrey
left a comment
There was a problem hiding this comment.
Looks great, just two minor comments
aa2ef9d to
fd6da8c
Compare
…_nonzeros_heuristic
…_nonzeros_heuristic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estimate the number of non-zeros (
njmax_nnz) in the sparse constraint Jacobian.Non-contact constraints (assume all active)
_body_pair_nnz(body1, body2)_body_pair_nnz(body1, body2)flexedge_J_rownnzten_J_rownnzten_J_rownnzContact constraints
pair_geom1/2)_body_pair_nnz(body1, body2)for each pairmax_contact_nnznjmax × max_contact_nnzEstimate
Helper:
_body_pair_nnz(body1, body2)Counts unique DOFs in the kinematic tree union of two bodies by walking up
both
dof_parentidchains simultaneously (same algorithm as runtime constraint kernels).Validation for benchmark scenes* with sparse constraint Jacobians
*aloha sdf skipped