Skip to content

Conversation

@sulsikan
Copy link
Contributor

๐Ÿ“Œ PR ๊ฐœ์š”

ํ•ด๋‹น PR์ด ํฌํ•จํ•˜๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ ๋˜๋Š” ๋ชฉ์ ์„ ๊ฐ„๋žตํžˆ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.

  • ๋ฆฌ๋ทฐ๊ฐ€ 0๊ฑด ์ธ ์ œํ’ˆ์˜ ๋ฐ์ดํ„ฐ๋ฅผ ์ˆ˜์ง‘ํ•  ๋•Œ ๋ฐœ์ƒ๋˜๋Š” ์—๋Ÿฌ๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๊ตฌ๋งค ์ƒ์„ธ ์ •๋ณด ๋กœ๊ทธ ์ถœ๋ ฅ์„ ์ˆ˜์ •ํ•˜์—ฌ ๋กœ๊ทธ ํ‘œ์‹œ ๋‚ด์šฉ์ด ์ˆ˜์ •๋์Šต๋‹ˆ๋‹ค.

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

์ฝ”๋“œ ํ’ˆ์งˆ๊ณผ ํ˜‘์—… ํšจ์œจ์„ ์œ„ํ•ด ๋ณ‘ํ•ฉ ์ „์— ๋‹ค์Œ์˜ ์งˆ๋ฌธ์„ ๊ธฐ๋ฐ˜์œผ๋กœ ์ ๊ฒ€ํ•ด์ฃผ์„ธ์š”.

  • ์ฝ”๋“œ๊ฐ€ ์ž˜ ์‹คํ–‰๋ผ์š” (์—๋Ÿฌ ์—†์–ด์š”)
  • ๋‚ด ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ๋‹ค๋ฅธ ํŒŒํŠธ์— ์˜ํ–ฅ์„ ์ฃผ์ง€ ์•Š์•„์š” (๊ฐ€๋Šฅํ•˜๋ฉด!)
  • ํŒ€์—์„œ ์ •ํ•œ ์ฝ”๋“œ ์Šคํƒ€์ผ๊ณผ ์ปค๋ฐ‹ ์ปจ๋ฒค์…˜์„ ์ž˜ ๋”ฐ๋ž์–ด์š”
  • ๊ด€๋ จ ์ด์Šˆ๋‚˜ ์„ค๋ช…์ด ํ•„์š”ํ•œ ๋‚ด์šฉ์€ ์•„๋ž˜์— ์ ์—ˆ์–ด์š”

โœ๏ธ ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ

ํ•ต์‹ฌ ๋ณ€๊ฒฝ๋“ค์„ ์ž์œ ๋กญ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

  • ๋ฆฌ๋ทฐ๊ฐ€ 0๊ฑด์ธ ์ œํ’ˆ ๋ฐ์ดํ„ฐ ์ˆ˜์ง‘ ์‹œ ์—๋Ÿฌ ๋ฐœ์ƒ
    โ†’ crawlers/skincare/crawl_rank_skincare.pyํŒŒ์ผ์—์„œ totalComment ๊ฐ€ if๋ฌธ ์•ˆ์— ์„ ์–ธ๋˜์–ด ์žˆ์–ด, ๊ฐ’ ๋ฆฌํ„ด ์‹œ ์—๋Ÿฌ๊ฐ€ ๋ฐœ์ƒํ•ฉ๋‹ˆ๋‹ค.
    โ†’ if ๋ฌธ ๋ฐ–์— totalComment๋ฅผ ์ดˆ๊ธฐํ™”ํ•˜๋Š” ์ฝ”๋“œ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
    โ†’ ๋ฆฌ๋ทฐ๊ฐ€ 0๊ฑด์ผ ์‹œ "[get_product_detail_info] ๋ฆฌ๋ทฐ ์ •๋ณด ์—†์Œ: ๋ฆฌ๋ทฐ ์ˆ˜๊ฐ€ 0๊ฑด ์ž…๋‹ˆ๋‹ค." ๋กœ๊ทธ ๋ฉ”์‹œ์ง€๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

  • ๊ตฌ๋งค ์ƒ์„ธ ์ •๋ณด ๋กœ๊ทธ ์ถœ๋ ฅ์„ ์ˆ˜์ •ํ•˜์—ฌ ๋กœ๊ทธ ํ‘œ์‹œ ๋‚ด์šฉ์ด ์ˆ˜์ •๋์Šต๋‹ˆ๋‹ค.
    โ†’ before : ์„ฑ๋ถ„ ๋‚ด์šฉ๊นŒ์ง€ ๋ชจ๋‘ ๋กœ๊ทธ๋กœ ์ถœ๋ ฅ๋˜์–ด ๋งŽ์€ ์–‘์˜ ๋กœ๊ทธ๊ฐ€ ์ฐํž˜
    โ†’ after : ์„ฑ๋ถ„ ๋‚ด์šฉ์„ ์‚ญ์ œํ•˜๊ณ  ๋‹จ์ˆœ ์„ฑ๊ณต/์‹คํŒจ ์—ฌ๋ถ€๋งŒ ์ถœ๋ ฅํ•˜๋Š” ๋กœ๊ทธ๋กœ ์ˆ˜์ •

๐Ÿงช ๐Ÿ“ท ์Šคํฌ๋ฆฐ์ƒท or ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ (์„ ํƒ)

์ดํ•ด์— ๋„์›€๋  ์Šคํฌ๋ฆฐ์ƒท์„ ์ฒจ๋ถ€ํ•ด์ฃผ์„ธ์š”.

๐Ÿ“Ž ๊ด€๋ จ ์ด์Šˆ

๊ด€๋ จ๋œ ์ด์Šˆ ๋ฒˆํ˜ธ๋ฅผ ์ ์–ด์ฃผ์„ธ์š”. (์˜ˆ: #12, JIRA-23 ๋“ฑ)

๐Ÿ’ฌ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ํ•˜๊ณ  ์‹ถ์€ ๋ง (์„ ํƒ)

์„ค๋ช…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„, ๊ณ ๋ฏผํ–ˆ๋˜ ์ , ๋ฆฌ๋ทฐ ์š”์ฒญ ํฌ์ธํŠธ ๋“ฑ ์ž์œ ๋กญ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

@sulsikan sulsikan requested a review from jjunier as a code owner July 11, 2025 03:28
@jjunier jjunier merged commit 7da0b8b into main Jul 11, 2025
2 checks passed
@goosebumpsu goosebumpsu mentioned this pull request Jul 14, 2025
4 tasks
@jjunier jjunier added the bug Something isn't working label Jul 14, 2025
This was referenced Jul 14, 2025
@sulsikan sulsikan mentioned this pull request Jul 10, 2025
4 tasks
@jjunier jjunier mentioned this pull request Jul 10, 2025
4 tasks
@sulsikan sulsikan mentioned this pull request Jul 26, 2025
4 tasks
@kimwestg kimwestg mentioned this pull request Jul 27, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants