Feature/crawl skincare #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ PR ๊ฐ์
โ PR ์ฒดํฌ๋ฆฌ์คํธ
โ๏ธ ์ฃผ์ ๋ณ๊ฒฝ ์ฌํญ
๋ฆฌ๋ทฐ๊ฐ 0๊ฑด์ธ ์ ํ ๋ฐ์ดํฐ ์์ง ์ ์๋ฌ ๋ฐ์
โ crawlers/skincare/crawl_rank_skincare.pyํ์ผ์์ totalComment ๊ฐ if๋ฌธ ์์ ์ ์ธ๋์ด ์์ด, ๊ฐ ๋ฆฌํด ์ ์๋ฌ๊ฐ ๋ฐ์ํฉ๋๋ค.
โ if ๋ฌธ ๋ฐ์ totalComment๋ฅผ ์ด๊ธฐํํ๋ ์ฝ๋๋ฅผ ์ถ๊ฐํ์ต๋๋ค.
โ ๋ฆฌ๋ทฐ๊ฐ 0๊ฑด์ผ ์ "[get_product_detail_info] ๋ฆฌ๋ทฐ ์ ๋ณด ์์: ๋ฆฌ๋ทฐ ์๊ฐ 0๊ฑด ์ ๋๋ค." ๋ก๊ทธ ๋ฉ์์ง๋ฅผ ์ถ๊ฐํ์ต๋๋ค.
๊ตฌ๋งค ์์ธ ์ ๋ณด ๋ก๊ทธ ์ถ๋ ฅ์ ์์ ํ์ฌ ๋ก๊ทธ ํ์ ๋ด์ฉ์ด ์์ ๋์ต๋๋ค.
โ before : ์ฑ๋ถ ๋ด์ฉ๊น์ง ๋ชจ๋ ๋ก๊ทธ๋ก ์ถ๋ ฅ๋์ด ๋ง์ ์์ ๋ก๊ทธ๊ฐ ์ฐํ
โ after : ์ฑ๋ถ ๋ด์ฉ์ ์ญ์ ํ๊ณ ๋จ์ ์ฑ๊ณต/์คํจ ์ฌ๋ถ๋ง ์ถ๋ ฅํ๋ ๋ก๊ทธ๋ก ์์
๐งช ๐ท ์คํฌ๋ฆฐ์ท or ํ ์คํธ ๊ฒฐ๊ณผ (์ ํ)
๐ ๊ด๋ จ ์ด์
๐ฌ ๋ฆฌ๋ทฐ์ด์๊ฒ ํ๊ณ ์ถ์ ๋ง (์ ํ)