Skip to content

Make Codecov patch coverage informational - #1448

Open
p-keminer wants to merge 2 commits into
justcallmekoko:developfrom
p-keminer:ci/informational-codecov-patch
Open

Make Codecov patch coverage informational#1448
p-keminer wants to merge 2 commits into
justcallmekoko:developfrom
p-keminer:ci/informational-codecov-patch

Conversation

@p-keminer

Copy link
Copy Markdown

Summary

  • keep the whole-firmware coverage baseline and its zero-hit hardware-source reporting
  • make only codecov/patch informational so uncovered firmware diffs remain visible without presenting hardware/PCAP-tested changes as failed CI
  • leave the native Unity tests, firmware build matrix, and codecov/project behavior unchanged

Why

The native PlatformIO target currently builds only the host-testable MarauderMacAddress.cpp. The whole-source coverage step intentionally records all other firmware implementation lines as uncovered. As a result, ordinary UI, WiFi, SD, BLE, and RF changes receive 0% patch coverage even when the native tests and all firmware builds pass.

Validation

  • official Codecov YAML validator: Valid!
  • git diff --check
  • one new repository-root file only; no firmware or workflow changes

Once this lands, existing firmware PR checks can be rerun after synchronizing with the updated develop branch.

Copilot AI lite review requested due to automatic review settings August 9, 2026 19:03
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.40%. Comparing base (66f3c81) to head (871ab84).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1448   +/-   ##
=======================================
  Coverage     0.40%   0.40%           
=======================================
  Files           20      20           
  Lines        17176   17176           
  Branches        11      11           
=======================================
  Hits            69      69           
  Misses       17103   17103           
  Partials         4       4           
Flag Coverage Δ
firmware-unit-tests 0.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a minimal Codecov configuration to make the codecov/patch status check informational, while leaving overall/project coverage behavior intact so whole-firmware coverage remains visible (including intentional zero-hit hardware-bound lines) without blocking CI on patch coverage.

Changes:

  • Introduce a repository-root codecov.yml configuring coverage.status.patch.default.informational: true.
  • Document (via header comments) why patch coverage is informational given the current native harness coverage limitations.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants