Make Codecov patch coverage informational - #1448
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1448 +/- ##
=======================================
Coverage 0.40% 0.40%
=======================================
Files 20 20
Lines 17176 17176
Branches 11 11
=======================================
Hits 69 69
Misses 17103 17103
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a minimal Codecov configuration to make the codecov/patch status check informational, while leaving overall/project coverage behavior intact so whole-firmware coverage remains visible (including intentional zero-hit hardware-bound lines) without blocking CI on patch coverage.
Changes:
- Introduce a repository-root
codecov.ymlconfiguringcoverage.status.patch.default.informational: true. - Document (via header comments) why patch coverage is informational given the current native harness coverage limitations.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
codecov/patchinformational so uncovered firmware diffs remain visible without presenting hardware/PCAP-tested changes as failed CIcodecov/projectbehavior unchangedWhy
The native PlatformIO target currently builds only the host-testable
MarauderMacAddress.cpp. The whole-source coverage step intentionally records all other firmware implementation lines as uncovered. As a result, ordinary UI, WiFi, SD, BLE, and RF changes receive 0% patch coverage even when the native tests and all firmware builds pass.Validation
Valid!git diff --checkOnce this lands, existing firmware PR checks can be rerun after synchronizing with the updated
developbranch.